Skip to content

esm: ensure watch mode restarts after syntax errors #61232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Xstoudi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

esm: ensure watch mode restarts after syntax errors #61232

Xstoudi wants to merge 3 commits into from

Conversation

@Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Jan 1, 2026

Move watch dependency reporting earlier in module resolution to ensure file dependencies are tracked even when parsing fails.

Fixes: #61153

@Xstoudi
esm: ensure watch mode restarts after syntax errors
31caef8 
Move watch dependency reporting earlier in module resolution to ensure
file dependencies are tracked even when parsing fails.

Fixes: nodejs#61153
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 1, 2026

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jan 1, 2026
@codecov
Copy link

codecov bot commented Jan 1, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (ce2ec3d) to head (91fddbe).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/modules/esm/loader.js 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61232      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208734   208743       +9     
  Branches    40271    40267       -4     
==========================================
- Hits       184823   184814       -9     
- Misses      15932    15948      +16     
- Partials     7979     7981       +2
Files with missing lines Coverage Δ
lib/internal/modules/esm/loader.js 96.96% <83.33%> (+<0.01%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito
Copy link
Member

marco-ippolito commented Jan 1, 2026

Can you add a test?

@Xstoudi
Copy link
Contributor Author

Xstoudi commented Jan 2, 2026

Just added a test, let me know if that's too broad and shouldn't be tested through cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node --watch won't restart after SyntaxError [ERR_INVALID_TYPESCRIPT_SYNTAX] and the file is subsequently modified

4 participants

@Xstoudi @nodejs-github-bot @marco-ippolito @avivkeller